Skip to content

Conversation

myteron
Copy link
Contributor

@myteron myteron commented Feb 27, 2025

Adding documentation to code as part of #531
Code examples had to be replaced

@myteron myteron changed the title Py scg doc 798 pySCG: doc 798 Feb 27, 2025
Copy link
Contributor

@BartyBoi1128 BartyBoi1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested few changes, forgot I can do that in first review...

Copy link
Contributor Author

@myteron myteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied changes except for the linkt

Signed-off-by: Helge Wehder <[email protected]>
@myteron myteron requested a review from BartyBoi1128 March 13, 2025 14:15
Copy link
Contributor Author

@myteron myteron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added most of the change requests

Copy link
Contributor

@s19110 s19110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, just commit your suggestions and we can merge it.

@myteron myteron merged commit 1ebe68b into ossf:main Mar 24, 2025
2 checks passed
@myteron myteron moved this from Backlog to Done in Python Secure Coding Guide Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants